Bug 222086 - Adopt VM_FLAGS_PERMANENT for the config vm mapping
Summary: Adopt VM_FLAGS_PERMANENT for the config vm mapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-17 18:06 PST by Saam Barati
Modified: 2021-05-18 14:20 PDT (History)
11 users (show)

See Also:

Attachments
WIP (3.03 KB, patch)
2021-02-17 18:12 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (3.85 KB, patch)
2021-03-08 16:32 PST, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (3.84 KB, patch)
2021-03-08 16:54 PST, Saam Barati 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (5.22 KB, patch)
2021-03-09 12:04 PST, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (6.39 KB, patch)
2021-03-11 14:42 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-02-17 18:06:20 PST 
...
Comment 1 Saam Barati 2021-02-17 18:08:13 PST 
<rdar://74402690>
Comment 2 Saam Barati 2021-02-17 18:12:38 PST 
Created attachment 420778 [details]
WIP
Comment 3 Saam Barati 2021-03-08 16:32:09 PST 
Created attachment 422634 [details]
patch
Comment 4 Saam Barati 2021-03-08 16:54:22 PST 
Created attachment 422639 [details]
patch

Try to fix the build error.

I'll also look into the style error w.r.t my version checks.
Comment 5 Yusuke Suzuki 2021-03-08 17:04:28 PST 
Comment on attachment 422639 [details]
patch

r=me
Comment 6 Saam Barati 2021-03-09 12:04:50 PST 
Created attachment 422738 [details]
patch for landing
Comment 7 Saam Barati 2021-03-11 14:42:48 PST 
Created attachment 422973 [details]
patch for landing

Let's test EWS on this.
Comment 8 EWS 2021-03-11 21:44:00 PST 
Committed r274325: <https://commits.webkit.org/r274325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422973 [details].
Comment 9 Alex Christensen 2021-03-12 07:48:39 PST 
Comment on attachment 422973 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review

> Source/WTF/wtf/WTFConfig.cpp:75
> +        RELEASE_ASSERT(result == KERN_SUCCESS);

I'm hitting this assertion.
Comment 10 Alex Christensen 2021-03-12 09:15:09 PST 
Never mind.  Configuration issue on my part.
Comment 11 Alex Christensen 2021-05-18 13:54:40 PDT 
Comment on attachment 422973 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:169
> +    WTF::initializeMainThread();

This is too early.  It causes SafariForWebKitDevelopment to crash because it calls a function from JavaScriptCore.framework before we have loaded the framework.  What was the intent of adding this?
Comment 12 Alex Christensen 2021-05-18 14:20:45 PDT 
Comment on attachment 422973 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=422973&action=review

>> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:169
>> +    WTF::initializeMainThread();
> 
> This is too early.  It causes SafariForWebKitDevelopment to crash because it calls a function from JavaScriptCore.framework before we have loaded the framework.  What was the intent of adding this?

Just kidding.  It seems to work fine.