Bug 222068 - DumpRenderTree's createWebViewAndOffscreenWindow() should return a RetainPtr
Summary: DumpRenderTree's createWebViewAndOffscreenWindow() should return a RetainPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 222009
Blocks:
  Show dependency treegraph
 
Reported: 2021-02-17 14:09 PST by Chris Dumez
Modified: 2021-02-17 18:27 PST (History)
8 users (show)

See Also:


Attachments
Patch (5.16 KB, patch)
2021-02-17 14:10 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-02-17 14:09:48 PST
DumpRenderTree's createWebViewAndOffscreenWindow() should return a RetainPtr.
Comment 1 Chris Dumez 2021-02-17 14:10:54 PST
Created attachment 420711 [details]
Patch
Comment 2 EWS 2021-02-17 16:24:58 PST
Committed r273046: <https://commits.webkit.org/r273046>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420711 [details].
Comment 3 Radar WebKit Bug Importer 2021-02-17 16:25:43 PST
<rdar://problem/74454987>
Comment 4 Darin Adler 2021-02-17 16:28:14 PST
Comment on attachment 420711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420711&action=review

> Source/WTF/wtf/Forward.h:74
> +#if USE(CF) || defined(__OBJC__)

Not sure we need the conditional; I don’t think it does harm to have this declaration on platforms where it doesn’t exist.

> Source/WTF/wtf/Forward.h:146
> +#if USE(CF) || defined(__OBJC__)

Ditto.
Comment 5 Chris Dumez 2021-02-17 18:27:12 PST
(In reply to Darin Adler from comment #4)
> Comment on attachment 420711 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420711&action=review
> 
> > Source/WTF/wtf/Forward.h:74
> > +#if USE(CF) || defined(__OBJC__)
> 
> Not sure we need the conditional; I don’t think it does harm to have this
> declaration on platforms where it doesn’t exist.
> 
> > Source/WTF/wtf/Forward.h:146
> > +#if USE(CF) || defined(__OBJC__)
> 
> Ditto.

Ok. I followed up with <https://commits.webkit.org/r273056>.