RESOLVED FIXED 222048
Use element fullscreen for video on some configurations 
https://bugs.webkit.org/show_bug.cgi?id=222048
Summary Use element fullscreen for video on some configurations
Dean Jackson
Reported 2021-02-17 10:15:36 PST
Enable element fullscreen for video on some configurations
Attachments
Patch (1.04 KB, patch)
2021-02-17 10:24 PST, Dean Jackson 		sam: review-
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Updated patch (1.04 KB, patch)
2021-02-17 10:27 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-17 10:22:39 PST
<rdar://problem/74439214>
Dean Jackson
Comment 2 2021-02-17 10:24:57 PST
Created attachment 420664 [details] Patch
Sam Weinig
Comment 3 2021-02-17 10:26:42 PST
Comment on attachment 420664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420664&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:549 > +#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) && HAVE(UIKIT_WEBKIT_INTERNALS) This should be #if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) || HAVE(UIKIT_WEBKIT_INTERNALS))
Dean Jackson
Comment 4 2021-02-17 10:27:13 PST
Created attachment 420665 [details] Updated patch
EWS
Comment 5 2021-02-17 12:32:03 PST
Committed r273020: <https://commits.webkit.org/r273020> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420665 [details].
Note You need to log in before you can comment on or make changes to this bug.