Bug 222048 - Use element fullscreen for video on some configurations
Summary: Use element fullscreen for video on some configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-17 10:15 PST by Dean Jackson
Modified: 2021-02-17 12:32 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.04 KB, patch)
2021-02-17 10:24 PST, Dean Jackson 		sam: review-
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Updated patch (1.04 KB, patch)
2021-02-17 10:27 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-02-17 10:15:36 PST 
Enable element fullscreen for video on some configurations
Comment 1 Radar WebKit Bug Importer 2021-02-17 10:22:39 PST 
<rdar://problem/74439214>
Comment 2 Dean Jackson 2021-02-17 10:24:57 PST 
Created attachment 420664 [details]
Patch
Comment 3 Sam Weinig 2021-02-17 10:26:42 PST 
Comment on attachment 420664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420664&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:549
> +#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) && HAVE(UIKIT_WEBKIT_INTERNALS)

This should be 

#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) || HAVE(UIKIT_WEBKIT_INTERNALS))
Comment 4 Dean Jackson 2021-02-17 10:27:13 PST 
Created attachment 420665 [details]
Updated patch
Comment 5 EWS 2021-02-17 12:32:03 PST 
Committed r273020: <https://commits.webkit.org/r273020>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420665 [details].