Bug 222046 - [Cocoa] Web Inspector: add support for using custom process pool and page group identifier
Summary: [Cocoa] Web Inspector: add support for using custom process pool and page gro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Blaze Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-17 09:05 PST by Blaze Burg
Modified: 2021-02-18 16:09 PST (History)
8 users (show)

See Also:

Attachments
Patch v1.0 (25.21 KB, patch)
2021-02-17 16:54 PST, Blaze Burg 		no flags Details | Formatted Diff | Diff
Patch v1.1 (22.12 KB, patch)
2021-02-17 23:59 PST, Blaze Burg 		no flags Details | Formatted Diff | Diff
Patch v1.2 (20.91 KB, patch)
2021-02-18 09:58 PST, Blaze Burg 		timothy: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Blaze Burg 2021-02-17 09:05:19 PST 
<rdar://74180162>
Comment 1 Blaze Burg 2021-02-17 16:54:55 PST 
Created attachment 420761 [details]
Patch v1.0
Comment 2 Blaze Burg 2021-02-17 23:59:24 PST 
Created attachment 420801 [details]
Patch v1.1
Comment 3 Blaze Burg 2021-02-18 09:47:20 PST 
3 GTK API tests are failing, which looks relevant:

Unexpected timeouts (3)
    /WebKit2Gtk/TestInspector
        /webkit/WebKitWebInspector/custom-container-destroyed
        /webkit/WebKitWebInspector/manual-attach-detach
        /webkit/WebKitWebInspector/default
Comment 4 Blaze Burg 2021-02-18 09:49:52 PST 
Comment on attachment 420801 [details]
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=420801&action=review

> Source/WebKit/UIProcess/Inspector/WebInspectorUtilities.cpp:-85
> -        // Do not delay process launch for inspector pages as inspector pages do not know how to transition from a terminated process.

I'm pretty sure that this call was lost for non-Mac ports, so I'm going to duplicate it here and in the custom pools code path in WKInspectorViewController.
Comment 5 Blaze Burg 2021-02-18 09:58:26 PST 
Created attachment 420838 [details]
Patch v1.2
Comment 6 Blaze Burg 2021-02-18 16:09:48 PST 
Committed r273109 (234306@main): <https://commits.webkit.org/234306@main>