Bug 222041 - Enable MEDIA_SOURCE in IOS Simulator
Summary: Enable MEDIA_SOURCE in IOS Simulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-17 07:43 PST by youenn fablet
Modified: 2021-03-05 08:10 PST (History)
18 users (show)

See Also:

Attachments
Patch (10.15 KB, patch)
2021-02-17 07:53 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (11.29 KB, patch)
2021-02-17 08:44 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.09 KB, patch)
2021-02-18 01:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (20.94 KB, patch)
2021-02-19 01:38 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (21.58 KB, patch)
2021-02-19 04:28 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (24.52 KB, patch)
2021-03-01 07:24 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (24.51 KB, patch)
2021-03-02 02:58 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-02-17 07:43:24 PST 
Enable MEDIA_SOURCE in IOS Simulator
Comment 1 youenn fablet 2021-02-17 07:53:14 PST 
Created attachment 420648 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-02-17 07:54:08 PST 
<rdar://problem/74433510>
Comment 3 youenn fablet 2021-02-17 08:44:19 PST 
Created attachment 420652 [details]
Patch
Comment 4 youenn fablet 2021-02-18 01:48:28 PST 
Created attachment 420809 [details]
Patch
Comment 5 Eric Carlson 2021-02-18 08:32:29 PST 
Comment on attachment 420809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420809&action=review

> LayoutTests/ChangeLog:9
> +        * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

It is probably worth mentioning why this has changed.
Comment 6 youenn fablet 2021-02-19 00:50:38 PST 
imported/w3c/web-platform-tests/html/dom/idlharness.https.html is crashing in iOS sim debug since getAVStreamDataParserClass() returns nullptr.
I'll update the patch to disable MSE in WebKitTestRunner for now.
It would be good to fix this though.
Comment 7 youenn fablet 2021-02-19 01:38:44 PST 
Created attachment 420940 [details]
Patch
Comment 8 youenn fablet 2021-02-19 04:28:36 PST 
Created attachment 420955 [details]
Patch
Comment 9 youenn fablet 2021-02-19 05:56:28 PST 
Comment on attachment 420955 [details]
Patch

Redoing a round of review since patch changed a bit
Comment 10 youenn fablet 2021-03-01 07:24:21 PST 
Created attachment 421821 [details]
Patch
Comment 11 Eric Carlson 2021-03-01 09:25:22 PST 
Comment on attachment 421821 [details]
Patch

r=me once the bots are happy
Comment 12 youenn fablet 2021-03-01 11:28:12 PST 
Comment on attachment 421821 [details]
Patch

Oh, didn't see Eric comment
Comment 13 youenn fablet 2021-03-02 02:58:00 PST 
Created attachment 421918 [details]
Patch for landing
Comment 14 EWS 2021-03-02 07:37:28 PST 
Committed r273730: <https://commits.webkit.org/r273730>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421918 [details].
Comment 15 Alex Christensen 2021-03-05 08:10:23 PST 
r273968