RESOLVED FIXED 222038
commit-queue should retry when it fails to commit 
https://bugs.webkit.org/show_bug.cgi?id=222038
Summary commit-queue should retry when it fails to commit
Aakash Jain
Reported 2021-02-17 06:26:15 PST
commit-queue has been frequently failing to commit since we moved ews to github (see https://lists.webkit.org/pipermail/webkit-dev/2021-February/031686.html). Most of the times it succeeds on retry. One reason for that might be that there is a delay in syncing between svn.webkit.org and github.com (since we canonicalize the commits before pushing them to github which takes some time). Another reason for the failure is that sometimes between the time commit-queue updates to Tot, applies the patch and tries to commit; there might be another commit on trunk which modifies one of the file being modified in the patch (often ChangeLog), causing the file to be out of date. commit-queue should automatically retry to commit before giving up (while handling above situations appropriately).
Attachments
Patch (3.66 KB, patch)
2021-02-17 06:29 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-02-17 06:29:22 PST
Created attachment 420636 [details] Patch
Aakash Jain
Comment 2 2021-02-17 06:30:24 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1707
EWS
Comment 3 2021-02-17 08:23:24 PST
Committed r273000: <https://commits.webkit.org/r273000> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420636 [details].
Radar WebKit Bug Importer
Comment 4 2021-02-17 08:24:13 PST
<rdar://problem/74434372>
Aakash Jain
Comment 5 2021-02-22 06:13:18 PST
This change was picked up by buildbot restart on 2021-02-20.
Aakash Jain
Comment 6 2021-03-13 08:17:55 PST
This retry helped in https://ews-build.webkit.org/#/builders/28/builds/9967
Note You need to log in before you can comment on or make changes to this bug.