Bug 222038 - commit-queue should retry when it fails to commit
Summary: commit-queue should retry when it fails to commit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-17 06:26 PST by Aakash Jain
Modified: 2021-12-23 12:47 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.66 KB, patch)
2021-02-17 06:29 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-02-17 06:26:15 PST
commit-queue has been frequently failing to commit since we moved ews to github (see https://lists.webkit.org/pipermail/webkit-dev/2021-February/031686.html). Most of the times it succeeds on retry. 

One reason for that might be that there is a delay in syncing between svn.webkit.org and github.com (since we canonicalize the commits before pushing them to github which takes some time).

Another reason for the failure is that sometimes between the time commit-queue updates to Tot, applies the patch and tries to commit; there might be another commit on trunk which modifies one of the file being modified in the patch (often ChangeLog), causing the file to be out of date.

commit-queue should automatically retry to commit before giving up (while handling above situations appropriately).
Comment 1 Aakash Jain 2021-02-17 06:29:22 PST
Created attachment 420636 [details]
Patch
Comment 2 Aakash Jain 2021-02-17 06:30:24 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1707
Comment 3 EWS 2021-02-17 08:23:24 PST
Committed r273000: <https://commits.webkit.org/r273000>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420636 [details].
Comment 4 Radar WebKit Bug Importer 2021-02-17 08:24:13 PST
<rdar://problem/74434372>
Comment 5 Aakash Jain 2021-02-22 06:13:18 PST
This change was picked up by buildbot restart on 2021-02-20.
Comment 6 Aakash Jain 2021-03-13 08:17:55 PST
This retry helped in https://ews-build.webkit.org/#/builders/28/builds/9967