Bug 222037 - Fix Selenium key code for ENTER in testdriver-vendor.js
Summary: Fix Selenium key code for ENTER in testdriver-vendor.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-17 06:10 PST by Manuel Rego Casasnovas
Modified: 2021-02-19 02:31 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2021-02-17 06:10 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2021-02-17 06:10:05 PST 
Fix Selenium key code for ENTER in testdriver-vendor.js
Comment 1 Manuel Rego Casasnovas 2021-02-17 06:10:20 PST 
Created attachment 420635 [details]
Patch
Comment 2 EWS Watchlist 2021-02-17 06:11:34 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Manuel Rego Casasnovas 2021-02-17 06:12:12 PST 
This was a mistake I did in the previous patch, checking other examples in LayoutTests they use eventSender.keyDown("\n") and not eventSender.keyDown("enter").
Comment 4 EWS 2021-02-19 02:30:31 PST 
Committed r273136: <https://commits.webkit.org/r273136>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420635 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-19 02:31:13 PST 
<rdar://problem/74516053>