WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
222037
Fix Selenium key code for ENTER in testdriver-vendor.js
https://bugs.webkit.org/show_bug.cgi?id=222037
Summary
Fix Selenium key code for ENTER in testdriver-vendor.js
Manuel Rego Casasnovas
Reported
2021-02-17 06:10:05 PST
Fix Selenium key code for ENTER in testdriver-vendor.js
Attachments
Patch
(1.74 KB, patch)
2021-02-17 06:10 PST
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1
2021-02-17 06:10:20 PST
Created
attachment 420635
[details]
Patch
EWS Watchlist
Comment 2
2021-02-17 06:11:34 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see
https://trac.webkit.org/wiki/WPTExportProcess
Manuel Rego Casasnovas
Comment 3
2021-02-17 06:12:12 PST
This was a mistake I did in the previous patch, checking other examples in LayoutTests they use eventSender.keyDown("\n") and not eventSender.keyDown("enter").
EWS
Comment 4
2021-02-19 02:30:31 PST
Committed
r273136
: <
https://commits.webkit.org/r273136
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 420635
[details]
.
Radar WebKit Bug Importer
Comment 5
2021-02-19 02:31:13 PST
<
rdar://problem/74516053
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug