Bug 222036 - Animated keyframe style needs to go through full style adjuster
Summary: Animated keyframe style needs to go through full style adjuster
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 221994 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-17 05:23 PST by Antti Koivisto
Modified: 2021-02-17 12:34 PST (History)
4 users (show)

See Also:

Attachments
wip (3.22 KB, patch)
2021-02-17 05:24 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (6.56 KB, patch)
2021-02-17 07:22 PST, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (6.63 KB, patch)
2021-02-17 08:35 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-02-17 05:23:15 PST 
You can make weird styles.
Comment 1 Antti Koivisto 2021-02-17 05:24:24 PST 
Created attachment 420632 [details]
wip
Comment 2 Antti Koivisto 2021-02-17 07:03:04 PST 
rdar://72421747
Comment 3 Antti Koivisto 2021-02-17 07:22:02 PST 
Created attachment 420642 [details]
patch
Comment 4 zalan 2021-02-17 08:27:17 PST 
Comment on attachment 420642 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420642&action=review

> Source/WebCore/style/StyleAdjuster.cpp:-589
> -    bool elementRespectsZIndex = style.position() != PositionType::Static || (parentBoxStyle && parentBoxStyle->isDisplayFlexibleOrGridBox());
> -
> -    if (elementRespectsZIndex && !style.hasAutoSpecifiedZIndex())
> -        style.setUsedZIndex(style.specifiedZIndex());
> -    else if (impact.contains(AnimationImpact::ForcesStackingContext))

I assume this is taken care of in Adjuster::adjust() now.

> Source/WebCore/style/StyleAdjuster.h:49
> +    void adjustAnimatedStyle(RenderStyle&, OptionSet<AnimationImpact>);

const?
Comment 5 Antti Koivisto 2021-02-17 08:35:37 PST 
Created attachment 420651 [details]
patch
Comment 6 Antti Koivisto 2021-02-17 08:36:08 PST 
> I assume this is taken care of in Adjuster::adjust() now.

Yeah, ChangeLog even mentions it.

> const?

Good point!
Comment 7 EWS 2021-02-17 09:27:27 PST 
Committed r273003: <https://commits.webkit.org/r273003>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420651 [details].
Comment 8 zalan 2021-02-17 12:34:16 PST 
*** Bug 221994 has been marked as a duplicate of this bug. ***