Bug 222022 - [iOS] Add support for additional accessibility image extraction contextmenu actions
Summary: [iOS] Add support for additional accessibility image extraction contextmenu a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-16 19:57 PST by Devin Rousso
Modified: 2021-02-17 09:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2021-02-16 19:58 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-02-16 19:57:26 PST 
.
Comment 1 Devin Rousso 2021-02-16 19:57:50 PST 
<rdar://problem/74157750>
Comment 2 Devin Rousso 2021-02-16 19:58:35 PST 
Created attachment 420584 [details]
Patch
Comment 3 Tim Horton 2021-02-16 20:45:25 PST 
Comment on attachment 420584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420584&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9718
> +static NSMutableArray<UIMenuElement *> *menuElementsFromDefaultActions(const RetainPtr<NSArray>& defaultElementActions, RetainPtr<_WKActivatedElementInfo> elementInfo)

For some reason I can't expand the context, is the return value really already a mutable array? (since you only change the type here)
Comment 4 Devin Rousso 2021-02-16 20:55:37 PST 
Comment on attachment 420584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420584&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9718
>> +static NSMutableArray<UIMenuElement *> *menuElementsFromDefaultActions(const RetainPtr<NSArray>& defaultElementActions, RetainPtr<_WKActivatedElementInfo> elementInfo)
> 
> For some reason I can't expand the context, is the return value really already a mutable array? (since you only change the type here)

Yes the return value (after the `nil` on :9721) is an `NSMutableArray`.
Comment 5 EWS 2021-02-17 09:37:00 PST 
Committed r273007: <https://commits.webkit.org/r273007>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420584 [details].