Now that webkitscmpy is a more mature package in production usage, we should update it's documentation.
Created attachment 420541 [details]
Comment on attachment 420541 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=420541&action=review
> +webkitcorepy along with fasteners, monotonic, whichcraft, and xmltodict.
nit: Think this would read better as bulleted list than as a sentence
> +The `git-webkit` command exposes much of the utility of the `webkitscmpy` library to the command line. Most notably:
nit: the utility of webktscmpy seems circular. We haven't defined what the utility is yet. Maybe replace with what the utility of webkitscmpy is
> +`git-webkit checout <ref>`: Move the current local repository to the provided git ref, Subversion revision or identifier.
> +`git-webkit canoniclize`: Standardize commit authorship and put identifiers into the commit message.
typo canonicalize. I think that's an awkward name for a command
> +The `webkitscmpy` library provides a repository abstraction for both local and remote repositories. Those abstractions
nit: Instead of Those abstractions can be instantiated in code like so
how about: To instantiate a repository object.
nit: Would this make more sense if it was assigned to a variable?
> +be missing from certain implementations. For example, remote repositories do not have a `checkout` command available.
nit how about While the abstraction layer is consistent for all implementations not all implementation support every feature. For example, ...
> +Each repository abstraction keeps a record contributors, which can be primed and passed into the repository object:
nit: record of contributors? list of contributor records?
Created attachment 420554 [details]
Patch for landing
Committed r272939: <https://commits.webkit.org/r272939>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 420554 [details].