Bug 221975 - Support aria-errormessage on iOS.
Summary: Support aria-errormessage on iOS.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-16 10:47 PST by Andres Gonzalez
Modified: 2021-02-17 05:00 PST (History)
9 users (show)

See Also:

Attachments
Patch (13.59 KB, patch)
2021-02-16 11:13 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (17.94 KB, patch)
2021-02-16 19:32 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-02-16 10:47:00 PST 
Support aria-errormessage on iOS.
Comment 1 Radar WebKit Bug Importer 2021-02-16 10:47:09 PST 
<rdar://problem/74397704>
Comment 2 Andres Gonzalez 2021-02-16 11:13:20 PST 
Created attachment 420502 [details]
Patch
Comment 3 chris fleizach 2021-02-16 11:16:43 PST 
Comment on attachment 420502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420502&action=review

> Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:303
> +    id elements = [m_element accessibilityErrorMessageElements];

we should be able to do
NSArray *elements here
and then we don't need to cast to NSArray at line 307

> LayoutTests/accessibility/aria-errormessage.html:9
> +<input aria-errormessage="errorMessage" id="startTime" type="text" value="" aria-invalid="false">

should we have to ids here to test the multi-error case?
Comment 4 Andres Gonzalez 2021-02-16 19:32:13 PST 
Created attachment 420583 [details]
Patch
Comment 5 Andres Gonzalez 2021-02-16 19:35:57 PST 
(In reply to chris fleizach from comment #3)
> Comment on attachment 420502 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420502&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:303
> > +    id elements = [m_element accessibilityErrorMessageElements];
> 
> we should be able to do
> NSArray *elements here
> and then we don't need to cast to NSArray at line 307

Fixed.
> 
> > LayoutTests/accessibility/aria-errormessage.html:9
> > +<input aria-errormessage="errorMessage" id="startTime" type="text" value="" aria-invalid="false">
> 
> should we have to ids here to test the multi-error case?

Done. Added AccessibilitUIElement::errorMessageElements to retrieve the whole array in the script instead of accessing one element at a time.
Comment 6 EWS 2021-02-17 05:00:51 PST 
Committed r272993: <https://commits.webkit.org/r272993>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420583 [details].