Bug 221959 - [iOS] Remove access to the Mobile asset service
Summary: [iOS] Remove access to the Mobile asset service
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-16 06:32 PST by Per Arne Vollan
Modified: 2021-02-16 18:42 PST (History)
2 users (show)

See Also:


Attachments
Patch (7.42 KB, patch)
2021-02-16 06:42 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (7.39 KB, patch)
2021-02-16 10:20 PST, Per Arne Vollan
bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (7.72 KB, patch)
2021-02-16 10:34 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-02-16 06:32:49 PST
Remove access to the Mobile asset service in the WebContent process, since there are no longer reports of this being in use.
Comment 1 Per Arne Vollan 2021-02-16 06:38:27 PST
<rdar://73362858>
Comment 2 Per Arne Vollan 2021-02-16 06:42:24 PST
Created attachment 420468 [details]
Patch
Comment 3 Brent Fulgham 2021-02-16 10:07:58 PST
Comment on attachment 420468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420468&action=review

It looks like this patch is out-of-date now. Can you regenerate so EWS can use it?

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-717
> -       (global-name "com.apple.mobileassetd" "com.apple.mobileassetd.v2"))

I guess we don't need to keep "mobleassetd.v2" because it is picked up by the dynamic case when Reader mode is used?
Comment 4 Per Arne Vollan 2021-02-16 10:20:59 PST
Created attachment 420492 [details]
Patch
Comment 5 Per Arne Vollan 2021-02-16 10:22:18 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 420468 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420468&action=review
> 
> It looks like this patch is out-of-date now. Can you regenerate so EWS can
> use it?
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-717
> > -       (global-name "com.apple.mobileassetd" "com.apple.mobileassetd.v2"))
> 
> I guess we don't need to keep "mobleassetd.v2" because it is picked up by
> the dynamic case when Reader mode is used?

Yes.

Thanks for reviewing!
Comment 6 Brent Fulgham 2021-02-16 10:23:22 PST
Comment on attachment 420492 [details]
Patch

r=me
Comment 7 Brent Fulgham 2021-02-16 10:23:40 PST
Comment on attachment 420492 [details]
Patch

r=me
Comment 8 Per Arne Vollan 2021-02-16 10:34:30 PST
Created attachment 420496 [details]
Patch
Comment 9 Per Arne Vollan 2021-02-16 18:09:46 PST
Comment on attachment 420496 [details]
Patch

Thanks for reviewing!
Comment 10 EWS 2021-02-16 18:42:29 PST
Committed r272975: <https://commits.webkit.org/r272975>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420496 [details].