Bug 221938 - [iOS] the tracks button should be emphasized while the media controls context menu is showing
Summary: [iOS] the tracks button should be emphasized while the media controls context...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 221937
Blocks:
  Show dependency treegraph
 
Reported: 2021-02-15 17:01 PST by Devin Rousso
Modified: 2021-02-17 13:37 PST (History)
13 users (show)

See Also:


Attachments
Patch (12.10 KB, patch)
2021-02-15 17:08 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (12.37 KB, patch)
2021-02-17 09:46 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-02-15 17:01:45 PST
this would make it clearer what originated the contextmenu
Comment 1 Devin Rousso 2021-02-15 17:08:09 PST
Created attachment 420397 [details]
Patch
Comment 2 Eric Carlson 2021-02-16 10:04:22 PST
Comment on attachment 420397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420397&action=review

> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:340
> +    if (m_showMediaControlsContextMenuCallback)
> +        return false;

If this condition is an error, it could be useful to have an ASSERT.
Comment 3 Devin Rousso 2021-02-17 09:45:12 PST
Comment on attachment 420397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420397&action=review

>> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:340
>> +        return false;
> 
> If this condition is an error, it could be useful to have an ASSERT.

This isn't an error condition.  There's nothing to stop the user from tapping on the overflow button when the tracks contextmenu is already shown.  This is a guard for that behavior.
Comment 4 Devin Rousso 2021-02-17 09:46:00 PST
Created attachment 420658 [details]
Patch
Comment 5 EWS 2021-02-17 13:36:21 PST
Committed r273024: <https://commits.webkit.org/r273024>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420658 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-17 13:37:16 PST
<rdar://problem/74447945>