this would make it clearer what originated the contextmenu
Created attachment 420397 [details] Patch
Comment on attachment 420397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420397&action=review > Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:340 > + if (m_showMediaControlsContextMenuCallback) > + return false; If this condition is an error, it could be useful to have an ASSERT.
Comment on attachment 420397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420397&action=review >> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:340 >> + return false; > > If this condition is an error, it could be useful to have an ASSERT. This isn't an error condition. There's nothing to stop the user from tapping on the overflow button when the tracks contextmenu is already shown. This is a guard for that behavior.
Created attachment 420658 [details] Patch
Committed r273024: <https://commits.webkit.org/r273024> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420658 [details].
<rdar://problem/74447945>