Bug 221924 - Web Inspector: Add checkbox to toggle all grid overlays
Summary: Web Inspector: Add checkbox to toggle all grid overlays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-15 14:13 PST by Nikita Vasilyev
Modified: 2021-03-10 23:28 PST (History)
5 users (show)

See Also:

Attachments
[Image] Mockup (138.26 KB, image/png)
2021-02-15 14:13 PST, Nikita Vasilyev 		no flags Details
Patch (6.80 KB, patch)
2021-03-10 17:48 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Video] With patch applied (2.44 MB, video/quicktime)
2021-03-10 17:51 PST, Nikita Vasilyev 		no flags Details
Patch (6.85 KB, patch)
2021-03-10 17:59 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2021-02-15 14:13:10 PST 
Created attachment 420369 [details]
[Image] Mockup

I encountered that most of the time I want to show/hide all grid overlays at once.
It would be handy to have a global checkbox.

When some grids are on and some are off, the global checkbox should have a partial state:
[-] Grid Overlays:
[v] div.column
[ ] section.Copy

This can be achieved with:
```
checkboxElement.indeterminate = true;
```
Comment 1 Radar WebKit Bug Importer 2021-02-15 14:13:19 PST 
<rdar://problem/74365101>
Comment 2 Nikita Vasilyev 2021-03-10 17:48:01 PST 
Created attachment 422889 [details]
Patch
Comment 3 Nikita Vasilyev 2021-03-10 17:51:37 PST 
Created attachment 422890 [details]
[Video] With patch applied
Comment 4 Nikita Vasilyev 2021-03-10 17:59:49 PST 
Created attachment 422892 [details]
Patch

Rebaselined.
Comment 5 BJ Burg 2021-03-10 23:09:09 PST 
Comment on attachment 422892 [details]
Patch

r=me
Comment 6 EWS 2021-03-10 23:28:54 PST 
Committed r274268: <https://commits.webkit.org/r274268>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422892 [details].