Bug 22189 - Track CachedScript decoded data
Summary: Track CachedScript decoded data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-11 15:46 PST by Sam Weinig
Modified: 2008-11-11 16:37 PST (History)
0 users

See Also:

Attachments
patch (3.37 KB, patch)
2008-11-11 15:53 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-11-11 15:46:33 PST 
Patch forthcoming.
Comment 1 Sam Weinig 2008-11-11 15:53:48 PST 
Created attachment 25078 [details]
patch
Comment 2 mitz 2008-11-11 15:58:44 PST 
Comment on attachment 25078 [details]
patch

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 38320)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,19 @@
> +2008-11-11  Sam Weinig  <sam@webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
> +        Track CachedScript decoded data
> +
> +        * loader/CachedResource.h:
> +        (WebCore::CachedResource::allClientsRemoved):
> +        (WebCore::CachedResource::destroyDecodedData):
> +        * loader/CachedScript.cpp:
> +        (WebCore::CachedScript::script):
> +        (WebCore::CachedScript::data):
> +        (WebCore::CachedScript::destroyDecodedData):
> +        * loader/CachedScript.h:
> +

You could explain the code changes.

> +    if (m_script.isNull() && m_data) {

You can write this as (!m_script && m_data).

r=me
Comment 3 Sam Weinig 2008-11-11 16:37:37 PST 
Fixed in r38321.