Bug 221883 - REGRESSION(r272842) [GStreamer] Layout tests exiting early due to crashes after GPUProcess for media enabled by default for WTR
Summary: REGRESSION(r272842) [GStreamer] Layout tests exiting early due to crashes aft...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-14 19:51 PST by Lauro Moura
Modified: 2021-02-15 03:40 PST (History)
6 users (show)

See Also:


Attachments
Provisional fix disabling the flag for GTK and WPE (1.52 KB, patch)
2021-02-14 19:59 PST, Lauro Moura
no flags Details | Formatted Diff | Diff
Version checking for GStreamer (1.51 KB, patch)
2021-02-15 02:50 PST, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Lauro Moura 2021-02-14 19:59:23 PST
Created attachment 420266 [details]
Provisional fix disabling the flag for GTK and WPE
Comment 2 Philippe Normand 2021-02-15 00:26:54 PST
Comment on attachment 420266 [details]
Provisional fix disabling the flag for GTK and WPE

View in context: https://bugs.webkit.org/attachment.cgi?id=420266&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:882
> +  condition: ENABLE(GPU_PROCESS) && !(PLATFORM(GTK) || PLATFORM(WPE))

&& !USE(GSTREAMER) would be a better test I think.
Comment 3 Lauro Moura 2021-02-15 02:50:05 PST
Created attachment 420295 [details]
Version checking for GStreamer
Comment 4 EWS 2021-02-15 03:39:07 PST
Committed r272848: <https://commits.webkit.org/r272848>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420295 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-15 03:40:19 PST
<rdar://problem/74344733>