Bug 221877 - Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth
Summary: Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-14 13:43 PST by Rob Buis
Modified: 2021-02-15 03:06 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.41 KB, patch)
2021-02-14 13:45 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2021-02-15 02:02 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2021-02-14 13:43:27 PST
Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth.
Comment 1 Rob Buis 2021-02-14 13:45:31 PST
Created attachment 420250 [details]
Patch
Comment 2 Sergio Villar Senin 2021-02-15 01:46:45 PST
Comment on attachment 420250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420250&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:491
> +    Optional<LayoutUnit> childOverrideWidth;

Nit: override -> overriding (we have recently switched the naming)
Comment 3 Rob Buis 2021-02-15 02:02:21 PST
Created attachment 420286 [details]
Patch
Comment 4 EWS 2021-02-15 03:05:54 PST
Committed r272846: <https://commits.webkit.org/r272846>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420286 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-15 03:06:14 PST
<rdar://problem/74344028>