Bug 221871 – Web Inspector: Add a way to wake up debuggables to the remote inspector protocol

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

We need a way to wake up debuggables on the target side for an application.

rdar://70351644

[Timothy Hatcher]

Created attachment 420228 [details]
Patch

[Devin Rousso]

Comment on attachment 420228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420228&action=review

> Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:96
> +void AutomationClient::requestedDebuggablesToWakeUp()

This feels kinda wrong IMO.  I don't think an Inspector feature should rely on anything `Automation*`.  I think it would be better to rename `RemoteInspector::Client` to `RemoteInspector::AutomationClient` and create a new `RemoteInspector::Client` that is initialized/inherited elsewhere.

[Timothy Hatcher]

Comment on attachment 420228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420228&action=review

>> Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:96
>> +void AutomationClient::requestedDebuggablesToWakeUp()
> 
> This feels kinda wrong IMO.  I don't think an Inspector feature should rely on anything `Automation*`.  I think it would be better to rename `RemoteInspector::Client` to `RemoteInspector::AutomationClient` and create a new `RemoteInspector::Client` that is initialized/inherited elsewhere.

It is only called `AutomationClient` in WebKit. It is technically the `RemoteInspectorClient`. It should be renamed at some point.

[Timothy Hatcher]

Created attachment 420385 [details]
Patch

[Devin Rousso]

Comment on attachment 420385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420385&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKAutomationDelegate.h:39
> +// FIXME: Consider renaming WebKit::AutomationClient and _WKAutomationDelegate to _WKInspectorDelegate since it isn't only used for automation now. http://webkit.org/b/221933

NIT: I'd put this in `RemoteInspector::receivedWakeUpDebuggables` and `AutomationClient::requestedDebuggablesToWakeUp` too so that it's more visible and less likely to be missed/forgotten :)

[Timothy Hatcher]

Comment on attachment 420385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420385&action=review

>> Source/WebKit/UIProcess/API/Cocoa/_WKAutomationDelegate.h:39
>> +// FIXME: Consider renaming WebKit::AutomationClient and _WKAutomationDelegate to _WKInspectorDelegate since it isn't only used for automation now. http://webkit.org/b/221933
> 
> NIT: I'd put this in `RemoteInspector::receivedWakeUpDebuggables` and `AutomationClient::requestedDebuggablesToWakeUp` too so that it's more visible and less likely to be missed/forgotten :)

I don't think `RemoteInspector::receivedWakeUpDebuggables` is a good place for that comment since RemoteInspector is the right place. The WebKit side is what needs changed.

[Timothy Hatcher]

Created attachment 420387 [details]
Patch

[EWS]

Committed r272889: <https://commits.webkit.org/r272889>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420387 [details].