Bug 22187 - CLEARTYPE_QUALITY flag is not supported on Win2000
Summary: CLEARTYPE_QUALITY flag is not supported on Win2000
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P4 Minor
Assignee: Ada Chan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-11 15:08 PST by Nathan Howell
Modified: 2008-11-11 15:34 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch - update window versions (1.13 KB, patch)
2008-11-11 15:23 PST, Ada Chan
sfalken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Howell 2008-11-11 15:08:00 PST
OS version numbers are referenced here: http://msdn.microsoft.com/en-us/library/aa383745(VS.85).aspx

LOGFONT says ClearType is supported on XP and up: http://msdn.microsoft.com/en-us/library/ms533931(VS.85).aspx


I'd guess this is a bug in the older Win2003 R2 Platform SDK. The current code breaks when compiling against the Win2008 SP1 (v6.1) PSDK, I've included the the small change required to WebKitLibraries to get things building again.


Index: WebKitLibraries/win/tools/vsprops/common.vsprops
===================================================================
--- WebKitLibraries/win/tools/vsprops/common.vsprops    (revision 38308)
+++ WebKitLibraries/win/tools/vsprops/common.vsprops    (working copy)
@@ -9,7 +9,7 @@
        <Tool
                Name="VCCLCompilerTool"
                AdditionalOptions="/GS"
-               PreprocessorDefinitions="WIN32;_WINDOWS;_WIN32_WINNT=0x500;_CRT_SECURE_NO_DEPRECATE;_SCL_SECURE_NO_DEPRECATE;__PRODUCTION__=0$(PRODUCTION);_HAS_EXCEPTIONS=0"
+               PreprocessorDefinitions="WIN32;_WINDOWS;_WIN32_WINNT=0x501;_CRT_SECURE_NO_DEPRECATE;_SCL_SECURE_NO_DEPRECATE;__PRODUCTION__=0$(PRODUCTION);_HAS_EXCEPTIONS=0"
                ExceptionHandling="0"
                RuntimeTypeInfo="false"
                WarningLevel="4"
Comment 1 Ada Chan 2008-11-11 15:23:12 PST
Created attachment 25077 [details]
Proposed patch - update window versions
Comment 2 Ada Chan 2008-11-11 15:34:04 PST
I've checked in r38319 that updates all the window version numbers to correspond to Windows XP.  Very similar to the change that Nathan proposed.