WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
221866
Rename `slotVisitor` variables to `visitor`.
https://bugs.webkit.org/show_bug.cgi?id=221866
Summary
Rename `slotVisitor` variables to `visitor`.
Mark Lam
Reported
2021-02-12 21:08:45 PST
In existing code, we sometimes name a SlotVisitor instance `slotVisitor` and sometimes just `visitor`. This patch makes it so that we use `visitor` consistently everywhere. This will also reduces the size of the GC verifier patch later. Also fixed a few typos in comments.
Attachments
proposed patch.
(30.31 KB, patch)
2021-02-12 21:14 PST
,
Mark Lam
ysuzuki
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2021-02-12 21:14:04 PST
Created
attachment 420206
[details]
proposed patch.
Mark Lam
Comment 2
2021-02-12 21:16:40 PST
The style complaints are bogus.
Yusuke Suzuki
Comment 3
2021-02-12 21:16:58 PST
Comment on
attachment 420206
[details]
proposed patch. r=me
Mark Lam
Comment 4
2021-02-12 21:31:39 PST
Thanks for the review. Landed in
r272830
: <
http://trac.webkit.org/r272830
>.
Radar WebKit Bug Importer
Comment 5
2021-02-12 21:32:14 PST
<
rdar://problem/74303534
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug