Bug 221863 - MobileSafari crashes at WebCore: WebCore::VideoFullscreenInterfaceAVKit::doEnterFullscreen
Summary: MobileSafari crashes at WebCore: WebCore::VideoFullscreenInterfaceAVKit::doEn...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
Keywords: InRadar
Depends on:
Reported: 2021-02-12 17:09 PST by Jean-Yves Avenard [:jya]
Modified: 2021-02-15 16:51 PST (History)
9 users (show)

See Also:

Patch (2.81 KB, patch)
2021-02-12 18:01 PST, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2021-02-13 02:37 PST, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-02-12 17:09:36 PST
UI process crashes at WebCore::VideoFullscreenInterfaceAVKit::doEnterFullscreen due to infinite recursion leading to stack exhaustion.
Comment 1 Jean-Yves Avenard [:jya] 2021-02-12 17:12:49 PST
Comment 2 Jean-Yves Avenard [:jya] 2021-02-12 18:01:43 PST
Created attachment 420203 [details]
Comment 3 Jean-Yves Avenard [:jya] 2021-02-13 02:32:04 PST
Comment on attachment 420203 [details]

I could make things go awry with this patch.
start playing a video (not YouTube), go to full screen. Now put the video in PiP and press the X button in the top right corner.

The video would exit PiP mode and go back to non-full screen but the video has now disappeared. Tapping play can only allow you to hear the video, but you can't see anything
Comment 4 Jean-Yves Avenard [:jya] 2021-02-13 02:37:11 PST
Created attachment 420218 [details]
Comment 5 Eric Carlson 2021-02-14 12:48:09 PST
Comment on attachment 420218 [details]

The Windows bot failure is unrelated, only iOS code is changed by this patch.
Comment 6 EWS 2021-02-14 12:51:05 PST
Committed r272841: <https://commits.webkit.org/r272841>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420218 [details].