Bug 221834 – enum LengthType -> enum class LengthType

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

enum LengthType -> enum class LengthType

[Myles C. Maxfield]

Created attachment 420158 [details]
Patch

[Sam Weinig]

Comment on attachment 420158 [details]
Patch

rs=me, but get it compiling.

[Myles C. Maxfield]

Created attachment 420160 [details]
Patch

[Myles C. Maxfield]

Created attachment 420164 [details]
Patch for committing

[EWS]

Committed r272805: <https://commits.webkit.org/r272805>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420164 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74289873>

[Darin Adler]

Comment on attachment 420164 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=420164&action=review

> Source/WebCore/ChangeLog:24
> +        iPhoneOS14.2.sdk/usr/include/MacTypes.h:193 has:
> +
> +        typedef SInt32 Fixed;
> +
> +        but we have:
> +
> +        enum LengthType {
> +            ... Fixed ...
> +        }
> +
> +        This leads to: error: reference to 'Fixed' is ambiguous
> +
> +        Unfortunately, this error occurs in
> +        /System/Library/Frameworks/CoreText.framework/Headers/SFNTLayoutTypes.h,
> +        which means we can't modify the error site to qualify the name. Therefore,
> +        the best solution is to turn enum LengthType into enum class LengthType.
> +        This is in accordance with WebKit's style guide.

This is only an issue if someone does:

    using namespace WebCore;

Then later includes SFNTLayoutTypes.h.

While this big enum class change is fine, another fix would be to reduce use of "using namespace WebCore" or technically to find the *incorrect* use of it, because it’s not correct to include a system framework after that.