Bug 221829 - [webkit-patch] Post both revision and identifier to bugzilla
Summary: [webkit-patch] Post both revision and identifier to bugzilla
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-12 10:46 PST by Jonathan Bedard
Modified: 2021-02-12 12:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.23 KB, patch)
2021-02-12 10:48 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (6.26 KB, patch)
2021-02-12 12:31 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-02-12 10:46:07 PST 
There has been indication that we want both the SVN revision and identifier in bugzilla commit comments.
Comment 1 Radar WebKit Bug Importer 2021-02-12 10:46:21 PST 
<rdar://problem/74282619>
Comment 2 Jonathan Bedard 2021-02-12 10:48:58 PST 
Created attachment 420147 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-12 12:31:21 PST 
Created attachment 420165 [details]
Patch
Comment 4 Aakash Jain 2021-02-12 12:33:42 PST 
Comment on attachment 420165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420165&action=review

> Tools/Scripts/webkitpy/tool/comments.py:40
> +    return 'Committed r{} ({}): <{}>'.format(

better to make it one line.
Comment 5 Jonathan Bedard 2021-02-12 12:38:07 PST 
Committed r272800 (234036@main): <https://commits.webkit.org/234036@main>