ASSIGNED 221803
WebGLRenderingContextBase::addMembersToOpaqueRoots() should also add m_defaultVertexArrayObject. 
https://bugs.webkit.org/show_bug.cgi?id=221803
Summary WebGLRenderingContextBase::addMembersToOpaqueRoots() should also add m_defaul...
Mark Lam
Reported 2021-02-11 20:30:28 PST
It currently does not.
Attachments
proposed patch. (2.46 KB, patch)
2021-02-11 20:38 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-02-11 20:38:02 PST
Created attachment 420087 [details] proposed patch.
Yusuke Suzuki
Comment 2 2021-02-11 20:47:29 PST
Comment on attachment 420087 [details] proposed patch. r=me
Kenneth Russell
Comment 3 2021-02-11 21:33:29 PST
Comment on attachment 420087 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=420087&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:7940 > + visitor.addOpaqueRoot(m_defaultVertexArrayObject.get()); m_defaultVertexArrayObject is never exposed to JavaScript; see this code which filters it out from the query of the current VAO: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp#L3337 It's not clear to me it has to be added to the opaque root set but if you think it does then this seems fine.
Radar WebKit Bug Importer
Comment 4 2021-02-18 20:31:13 PST
<rdar://problem/74507430>
Note You need to log in before you can comment on or make changes to this bug.