Bug 221799 - 'sync-commits.py' should be able to limit reporting scope to a specific branch on a Git repository.
Summary: 'sync-commits.py' should be able to limit reporting scope to a specific branc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-11 18:33 PST by dewei_zhu
Modified: 2021-02-12 15:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2021-02-11 18:36 PST, dewei_zhu 		no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2021-02-11 18:38 PST, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2021-02-11 18:33:07 PST 
'sync-commits.py' should be able to limit reporting scope to a specific branch on a Git repository.
Comment 1 dewei_zhu 2021-02-11 18:36:59 PST 
Created attachment 420076 [details]
Patch
Comment 2 dewei_zhu 2021-02-11 18:38:15 PST 
Created attachment 420077 [details]
Patch
Comment 3 Ryosuke Niwa 2021-02-12 01:33:56 PST 
Comment on attachment 420077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420077&action=review

I guess we don't have any tests for this script... We probably should.

> Websites/perf.webkit.org/tools/sync-commits.py:195
> -    def __init__(self, name, git_checkout, git_url):
> +    def __init__(self, name, git_checkout, git_url, git_branch):

should probably set the default parameter of None to signify the fact it's optional.
Comment 4 dewei_zhu 2021-02-12 15:05:48 PST 
rdar://74241548

Landed in r272814