Bug 221775 - Web Inspector: "Show Extended Gridlines" option for grid overlay does not work
Summary: Web Inspector: "Show Extended Gridlines" option for grid overlay does not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on: 221556
Blocks:
  Show dependency tree / graph
 
Reported: 2021-02-11 13:31 PST by Patrick Angle
Modified: 2021-02-11 18:57 PST (History)
12 users (show)

See Also:

Attachments
Patch (6.68 KB, patch)
2021-02-11 15:11 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (6.91 KB, patch)
2021-02-11 15:54 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-02-11 13:31:51 PST 
`OverlayManager.js:65` should set the `showExtendedGridlines` option, not `showExtendedGridLines` (different casing).
Comment 1 Nikita Vasilyev 2021-02-11 15:11:53 PST 
Created attachment 420049 [details]
Patch
Comment 2 Devin Rousso 2021-02-11 15:15:18 PST 
Comment on attachment 420049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420049&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        Replace all instances of "GridLines" (camelcase) with "Gridlines"
> +        to match the protocol naming.

I feel like this should actually be the opposite.  I think "GridLines" is more accurate here because you're drawing "lines for CSS grid contexts".  Not to mention it would likely be a smaller/simpler patch :P

Also, this shouldn't be problematic to update the protocol with a new name since we haven't included any of the grid related types/commands/events in any legacy protocols yet.
Comment 3 Nikita Vasilyev 2021-02-11 15:54:17 PST 
Created attachment 420058 [details]
Patch
Comment 4 EWS Watchlist 2021-02-11 15:55:08 PST 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 5 Devin Rousso 2021-02-11 16:18:53 PST 
Comment on attachment 420058 [details]
Patch

r=me
Comment 6 EWS 2021-02-11 18:56:57 PST 
Committed r272768: <https://commits.webkit.org/r272768>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420058 [details].
Comment 7 Radar WebKit Bug Importer 2021-02-11 18:57:15 PST 
<rdar://problem/74260822>