Bug 22176 - RenderThemeGtk depends on classes outside of platform
Summary: RenderThemeGtk depends on classes outside of platform
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 136338
Blocks: 21354 51662
  Show dependency treegraph
Reported: 2008-11-11 03:20 PST by Tor Arne Vestbø
Modified: 2014-08-29 01:06 PDT (History)
8 users (show)

See Also:

Patch (133.11 KB, patch)
2014-08-28 05:35 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2008-11-11 03:20:10 PST
This is a layering violation. The classes should perhaps be moved to WebCore/rendering like RenderThemeMac/Win.
Comment 1 Dirk Schulze 2011-01-01 14:40:31 PST
Why do we have a folder 'platform', if all platform related data can be all over the place? In my opinion it is confusing to have a lot of files in WebCore/rendering that are just used by a special platform (mainly Chromium, Mac and Win).
We had similar situations with HTML Canvas and SVG, where we placed all platform data in a subfolder, or in the _theoretically_ platform independent classes itself. It is much more efficient to work on the code, since we moved all these data to platform.
I think it makes it much more complicated to administer a port (or create new ports) if the platform dependent files are not concentrated and located on one place.

Maybe I misunderstood the sense of the name and folder 'platform', so sorry if I'm mistaken.
Comment 2 Carlos Garcia Campos 2013-04-07 05:27:11 PDT
I think we could create port specific directories in rendering (the same we have port dirs in other directories outside of platform like editing, page, plugins, etc.) and move all the RenderTheme<Port> files to rendering/<port> directories. This would fix the layering violations of RenderTheme files in platform.
Comment 3 Carlos Garcia Campos 2014-08-28 05:35:06 PDT
Created attachment 237307 [details]
Comment 4 Carlos Garcia Campos 2014-08-29 01:06:25 PDT
Committed r173111: <http://trac.webkit.org/changeset/173111>