Bug 221753 - Remove FontSelector dependence in CSSFontFace when creating a new FontFace wrapper
Summary: Remove FontSelector dependence in CSSFontFace when creating a new FontFace wr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks: 208351
  Show dependency tree / graph
 
Reported: 2021-02-11 06:53 PST by Chris Lord
Modified: 2021-02-11 08:07 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.47 KB, patch)
2021-02-11 06:57 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2021-02-11 07:23 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2021-02-11 06:53:16 PST 
As part of the work of removing the m_fontSelector member in CSSFontFace, we can remove a use of it when creating a FontFace wrapper by adding a parameter to provide the script execution context (which is the actual dependence, via FontSelector::document()).
Comment 1 Chris Lord 2021-02-11 06:57:53 PST 
Created attachment 419984 [details]
Patch
Comment 2 Myles C. Maxfield 2021-02-11 07:07:57 PST 
Comment on attachment 419984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419984&action=review

> Source/WebCore/css/FontFace.h:58
> +    static Ref<FontFace> create(ScriptExecutionContext*, CSSFontFace&);

How come this change doesn’t have an accompanying IDL change?
Comment 3 Myles C. Maxfield 2021-02-11 07:08:11 PST 
Comment on attachment 419984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419984&action=review

> Source/WebCore/css/FontFace.h:58
> +    static Ref<FontFace> create(ScriptExecutionContext*, CSSFontFace&);

How come this change doesn’t have an accompanying IDL change?
Comment 4 Chris Lord 2021-02-11 07:21:43 PST 
(In reply to Myles C. Maxfield from comment #3)
> Comment on attachment 419984 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419984&action=review
> 
> > Source/WebCore/css/FontFace.h:58
> > +    static Ref<FontFace> create(ScriptExecutionContext*, CSSFontFace&);
> 
> How come this change doesn’t have an accompanying IDL change?

This constructor doesn't feature in the idl and the one that does remains unchanged.
Comment 5 Chris Lord 2021-02-11 07:23:32 PST 
Created attachment 419986 [details]
Patch
Comment 6 EWS 2021-02-11 08:06:13 PST 
Committed r272727: <https://commits.webkit.org/r272727>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419986 [details].
Comment 7 Radar WebKit Bug Importer 2021-02-11 08:07:15 PST 
<rdar://problem/74234470>