Bug 221745 – [Mac] Add Experimental Opus Codec support

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac] Add Experimental Opus Codec support

[Jer Noble]

Created attachment 419953 [details]
Patch

[Jer Noble]

Created attachment 419955 [details]
Patch

[Jer Noble]

Created attachment 419956 [details]
Patch

[Jer Noble]

Created attachment 419992 [details]
Patch

[Chris Dumez]

Is this a dupe of https://bugs.webkit.org/show_bug.cgi?id=183852 ?

[Eric Carlson]

(In reply to Chris Dumez from comment #5)
> Is this a dupe of https://bugs.webkit.org/show_bug.cgi?id=183852 ?

No, this patch won't make Opus available to WebAudio.

[Jer Noble]

Created attachment 419999 [details]
Patch

[Eric Carlson]

Comment on attachment 419999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419999&action=review

r=me once the bots are happy

> Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:329
>      static dispatch_once_t onceToken;
>      dispatch_once(&onceToken, ^{
>          available = registerDecoderFactory("ACOpusDecoderFactory", 'opus');

It turns out we don't need to explicitly register the Opus codec component, so this can be removed.

[Ashley Gullen]

We've been desperate for WebM Opus support in Safari for years - all major browsers support it except Safari, making it an awkward compatibility problem to deal with when trying to get audio playback to work across browsers. It would be fantastic if support for this was added!

We also need support in Web Audio's decodeAudioData - is there a separate issue to track that? Is this just for the <audio> element so far?

Safari should support both at the same time, since the de-facto way to feature detect the types decodeAudioData can decode is via new Audio().canPlayType(). If that indicates support for WebM Opus when decodeAudioData does not support it, existing web content will be broken as it would incorrectly activate attempting to decode WebM Opus with decodeAudioData. Supporting both at the same time will avoid this problem.

[Jer Noble]

(In reply to Eric Carlson from comment #8)
> Comment on attachment 419999 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419999&action=review
> 
> r=me once the bots are happy
> 
> > Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:329
> >      static dispatch_once_t onceToken;
> >      dispatch_once(&onceToken, ^{
> >          available = registerDecoderFactory("ACOpusDecoderFactory", 'opus');
> 
> It turns out we don't need to explicitly register the Opus codec component,
> so this can be removed.

I'll remove this in a follow up patch.

[EWS]

commit-queue failed to commit attachment 419999 [details] to WebKit repository. To retry, please set cq+ flag again.

[EWS]

Committed r272758: <https://commits.webkit.org/r272758>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419999 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74255423>