Bug 221743 - [WebAuthn] Provide SPI to query local credentials
Summary: [WebAuthn] Provide SPI to query local credentials
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 22:23 PST by Jiewen Tan
Modified: 2021-02-12 17:40 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.76 KB, patch)
2021-02-10 22:26 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Patch (10.78 KB, patch)
2021-02-12 12:57 PST, Jiewen Tan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch for landing (10.94 KB, patch)
2021-02-12 16:56 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-02-10 22:23:01 PST 
Provide SPI to query local credentials.
Comment 1 Jiewen Tan 2021-02-10 22:23:15 PST 
<rdar://problem/65849832>
Comment 2 Jiewen Tan 2021-02-10 22:26:54 PST 
Created attachment 419945 [details]
Patch
Comment 3 Jiewen Tan 2021-02-12 12:57:35 PST 
Created attachment 420171 [details]
Patch
Comment 4 Brent Fulgham 2021-02-12 14:06:04 PST 
Comment on attachment 420171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420171&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:165
> +        (id)kSecClass: (id)kSecClassKey,

It's a shame so many casts are needed, but it looks like that's typical.

It looks like these are usually done as (__bridge id) in other code.

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:231
> +        (id)kSecClass: (id)kSecClassKey,

Suggest (__bridge id)
Comment 5 Jiewen Tan 2021-02-12 16:54:23 PST 
Comment on attachment 420171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420171&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:165
>> +        (id)kSecClass: (id)kSecClassKey,
> 
> It's a shame so many casts are needed, but it looks like that's typical.
> 
> It looks like these are usually done as (__bridge id) in other code.

Fixed.
Comment 6 Jiewen Tan 2021-02-12 16:56:20 PST 
Created attachment 420197 [details]
Patch for landing
Comment 7 EWS 2021-02-12 17:40:47 PST 
Committed r272826: <https://commits.webkit.org/r272826>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420197 [details].