Bug 221736 - [iOS] Some checkboxes and radio buttons are clipped on top
Summary: [iOS] Some checkboxes and radio buttons are clipped on top
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 19:40 PST by Aditya Keerthi
Modified: 2021-02-11 13:57 PST (History)
10 users (show)

See Also:

Attachments
Patch (17.19 KB, patch)
2021-02-10 19:43 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch for landing (17.21 KB, patch)
2021-02-10 20:29 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (17.17 KB, patch)
2021-02-11 08:03 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-02-10 19:40:33 PST 
...
Comment 1 Aditya Keerthi 2021-02-10 19:40:53 PST 
<rdar://problem/73956812>
Comment 2 Aditya Keerthi 2021-02-10 19:43:23 PST 
Created attachment 419938 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-02-10 20:02:42 PST 
Comment on attachment 419938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419938&action=review

> Source/WebCore/rendering/RenderTheme.h:104
> +    virtual LayoutRect adjustedPaintRect(const RenderBox&, const LayoutRect& paintRect) { return paintRect; }

This function can be const.
Comment 4 Aditya Keerthi 2021-02-10 20:29:02 PST 
Created attachment 419942 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-02-10 20:29:52 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 419938 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419938&action=review
> 
> > Source/WebCore/rendering/RenderTheme.h:104
> > +    virtual LayoutRect adjustedPaintRect(const RenderBox&, const LayoutRect& paintRect) { return paintRect; }
> 
> This function can be const.

Done. Thanks for the review!
Comment 6 Aditya Keerthi 2021-02-11 08:03:18 PST 
Created attachment 419988 [details]
Patch
Comment 7 Aditya Keerthi 2021-02-11 08:04:52 PST 
Added an is<RenderBox> check in RenderElement, to fix the crashing test.
Comment 8 EWS 2021-02-11 12:05:08 PST 
commit-queue failed to commit attachment 419988 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 9 EWS 2021-02-11 13:57:42 PST 
Committed r272749: <https://commits.webkit.org/r272749>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419988 [details].