Bug 221734 – Remove unused WebKit::LocalStorageDatabaseTracker::deleteAllDatabases()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

WebCore::SQLiteFileSystem::deleteEmptyDatabaseDirectory() in Source/WebCore/platform/sql/SQLiteFileSystem.h needs to be marked as WEBCORE_EXPORT so that it can be used in WebKit::LocalStorageDatabaseTracker::deleteAllDatabases() from Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp in WebKit.framework.

This probably hasn't been found before since WebKit.framework has dead code stripping unconditionally enabled via Source/WebKit/Configurations/Base.xcconfig:

// Dead code stripping needs to be on in the debug variant to avoid link errors.  This is due to unconditionally
// building the MiG bindings for WebKitPluginClient even when the functions that the bindings wrap are not built.
DEAD_CODE_STRIPPING = YES;

Most other WebKit projects disable dead code stripping in Debug builds like this:

DEAD_CODE_STRIPPING = YES;
DEAD_CODE_STRIPPING[config=Debug] = NO;

I guess this also means that LocalStorageDatabaseTracker::deleteAllDatabases() is dead code.

Maybe we can just delete LocalStorageDatabaseTracker::deleteAllDatabases() instead?

[David Kilzer (:ddkilzer)]

<rdar://problem/74215959>

[David Kilzer (:ddkilzer)]

Created attachment 420004 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 420004 [details]
Patch v1

Best kind of patch.

[EWS]

Committed r272754: <https://commits.webkit.org/r272754>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420004 [details].