Bug 221733 - [macOS] Add telemetry for a likely-unused call to ipc-posix-shm-read-data
Summary: [macOS] Add telemetry for a likely-unused call to ipc-posix-shm-read-data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 17:31 PST by Brent Fulgham
Modified: 2021-02-11 11:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2021-02-10 17:36 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (1.39 KB, patch)
2021-02-11 10:55 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-02-10 17:31:09 PST 
We don't think we need the following rules, but let's add some telemetry to confirm:

;; FIXME: Update for <rdar://problem/13642852>.
(allow ipc-posix-shm-read-data
    (ipc-posix-name "FNetwork.defaultStorageSession")
    (ipc-posix-name-regex #"\.PrivateBrowsing-")
    (ipc-posix-name-regex #"^WebKit Test-"))
Comment 1 Radar WebKit Bug Importer 2021-02-10 17:31:28 PST 
<rdar://problem/74214692>
Comment 2 Brent Fulgham 2021-02-10 17:36:15 PST 
Created attachment 419930 [details]
Patch
Comment 3 Per Arne Vollan 2021-02-10 18:06:36 PST 
Comment on attachment 419930 [details]
Patch

R=me.
Comment 4 EWS 2021-02-11 10:36:28 PST 
commit-queue failed to commit attachment 419930 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 EWS 2021-02-11 10:46:20 PST 
commit-queue failed to commit attachment 419930 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 6 Brent Fulgham 2021-02-11 10:55:41 PST 
Created attachment 420003 [details]
Patch for landing
Comment 7 EWS 2021-02-11 11:23:22 PST 
Committed r272741: <https://commits.webkit.org/r272741>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420003 [details].