Bug 221710 - [JSC] cloop broken on 32-bit big endian
Summary: [JSC] cloop broken on 32-bit big endian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 12:18 PST by Daniel Kolesa
Modified: 2021-02-18 15:20 PST (History)
8 users (show)

See Also:

Attachments
patch (2.48 KB, patch)
2021-02-10 12:19 PST, Daniel Kolesa 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (2.46 KB, patch)
2021-02-18 02:41 PST, Daniel Kolesa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kolesa 2021-02-10 12:18:16 PST 
Right now, JSC CLoop is broken (segfaults) on 32-bit BE systems (LE is fine, as is 64-bit LE and BE).
Comment 1 Daniel Kolesa 2021-02-10 12:19:21 PST 
Created attachment 419887 [details]
patch
Comment 2 Radar WebKit Bug Importer 2021-02-17 12:19:13 PST 
<rdar://problem/74444921>
Comment 3 Yusuke Suzuki 2021-02-17 12:23:04 PST 
Comment on attachment 419887 [details]
patch

r=me
Comment 4 EWS 2021-02-17 13:10:41 PST 
commit-queue failed to commit attachment 419887 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 Daniel Kolesa 2021-02-18 02:41:49 PST 
Created attachment 420817 [details]
patch

updated changelog
Comment 6 Daniel Kolesa 2021-02-18 02:49:02 PST 
oh, actually looks like it was just a failed push?

anything else needed from my side here?
Comment 7 Yusuke Suzuki 2021-02-18 12:38:08 PST 
(In reply to Daniel Kolesa from comment #6)
> oh, actually looks like it was just a failed push?
> 
> anything else needed from my side here?

Yeah, you need to put cq? and committer/reviewer can make it cq+ :)
Comment 8 EWS 2021-02-18 15:20:48 PST 
Committed r273104: <https://commits.webkit.org/r273104>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420817 [details].