Bug 221709 - Bubblewrap should determine which libdirs to bind properly
Summary: Bubblewrap should determine which libdirs to bind properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-10 12:06 PST by Daniel Kolesa
Modified: 2021-03-15 06:15 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.83 KB, patch)
2021-02-10 12:08 PST, Daniel Kolesa 		no flags Details | Formatted Diff | Diff
better patch (1.82 KB, patch)
2021-02-10 12:30 PST, Daniel Kolesa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kolesa 2021-02-10 12:06:36 PST 
On some 32-bit systems, webkitgtk with bubblewrap will not work as is, since glibc will direct its ld cache lookups through lib32 by default if it exists; if this path is not bound, the dynamic linker will fail to find the right libs. Right now the bubblewrap launcher unconditionally binds lib64. Therefore, it should be changed to conditionally bind either lib32 or lib64.
Comment 1 Daniel Kolesa 2021-02-10 12:08:32 PST 
Created attachment 419884 [details]
patch

not sure what the best way to do preprocessor conditional check for 64-bit systems would be here; this should probably be robust (but ugly)
Comment 2 Daniel Kolesa 2021-02-10 12:30:41 PST 
Created attachment 419888 [details]
better patch

use a WTF macro to check the pointer size
Comment 3 EWS 2021-03-15 06:15:10 PDT 
Committed r274417: <https://commits.webkit.org/r274417>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419888 [details].