Bug 221685 - [GPUP] Some modern-media-controls tests are flaky when media in GPU Process is enabled
Summary: [GPUP] Some modern-media-controls tests are flaky when media in GPU Process i...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 10:05 PST by Peng Liu
Modified: 2021-03-16 14:55 PDT (History)
9 users (show)

See Also:


Attachments
Remove passing tests from test expectations (2.61 KB, patch)
2021-03-01 15:35 PST, Peng Liu
no flags Details | Formatted Diff | Diff
Fix two flaky tests and update test expectations (10.67 KB, patch)
2021-03-10 21:21 PST, Peng Liu
no flags Details | Formatted Diff | Diff
Two tests are passing consistently now (2.45 KB, patch)
2021-03-16 10:23 PDT, Peng Liu
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-02-10 10:05:51 PST
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html
media/modern-media-controls/fullscreen-support/fullscreen-support-press.html
media/modern-media-controls/media-controller/media-controller-auto-hide.html
media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html
media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html
media/modern-media-controls/placard/placard-ltr.html
media/modern-media-controls/scrubber-support/scrubber-support-drag.html
media/modern-media-controls/seek-backward-support/seek-backward-support.html
Comment 1 Radar WebKit Bug Importer 2021-02-17 10:06:14 PST
<rdar://problem/74438431>
Comment 2 Peng Liu 2021-02-25 16:50:16 PST
http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html [ Timeout ]
http/tests/media/modern-media-controls/pip-support/pip-support-live-broadcast.html [ Timeout ]
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html [ Timeout ]
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-live-broadcast.html [ Timeout ]
http/tests/media/modern-media-controls/status-support/status-support-live-broadcast.html [ Timeout ]
http/tests/media/modern-media-controls/time-control/1-to-10-hours.html [ Timeout ]
http/tests/media/modern-media-controls/time-control/10-hours-or-more.html [ Timeout ]
http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html [ Timeout ]
http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html [ Timeout ]
Comment 3 Peng Liu 2021-03-01 15:35:17 PST
Created attachment 421878 [details]
Remove passing tests from test expectations
Comment 4 EWS 2021-03-01 16:10:06 PST
Committed r273701: <https://commits.webkit.org/r273701>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421878 [details].
Comment 5 Peng Liu 2021-03-01 16:15:03 PST
Reopen this bug because there are still some failing tests.
Comment 6 Peng Liu 2021-03-04 14:09:17 PST
Following two tests are passing consistently now:

http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html
media/modern-media-controls/fullscreen-support/fullscreen-support-press.html
Comment 7 Peng Liu 2021-03-10 21:21:45 PST
Created attachment 422899 [details]
Fix two flaky tests and update test expectations
Comment 8 EWS 2021-03-11 09:12:18 PST
Committed r274281: <https://commits.webkit.org/r274281>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422899 [details].
Comment 9 Peng Liu 2021-03-11 09:14:20 PST
Reopen this bug because there are 9 remaining test failures.
Comment 10 Peng Liu 2021-03-16 10:23:30 PDT
Created attachment 423352 [details]
Two tests are passing consistently now
Comment 11 EWS 2021-03-16 10:30:32 PDT
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 12 Peng Liu 2021-03-16 10:45:39 PDT
Committed r274492 (235348@main): <https://commits.webkit.org/235348@main>