RESOLVED FIXED 221680
[iOS][FCR] Add reduced motion animation for indeterminate progress bars 
https://bugs.webkit.org/show_bug.cgi?id=221680
Summary [iOS][FCR] Add reduced motion animation for indeterminate progress bars
Aditya Keerthi
Reported 2021-02-10 09:23:54 PST
...
Attachments
Patch (4.00 KB, patch)
2021-02-10 09:26 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2021-02-10 09:24:11 PST
<rdar://problem/74191515>
Aditya Keerthi
Comment 2 2021-02-10 09:26:04 PST
Created attachment 419855 [details] Patch
Wenson Hsieh
Comment 3 2021-02-10 09:28:47 PST
Comment on attachment 419855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419855&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:2217 > + context.fillRoundedRect(FloatRoundedRect(barRect, barCornerRadii), controlColor.colorWithAlphaByte(alpha * 255.0f)); Nit - could we just use `colorWithAlpha(alpha)` instead?
Aditya Keerthi
Comment 4 2021-02-10 09:36:11 PST
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 419855 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419855&action=review > > > Source/WebCore/rendering/RenderThemeIOS.mm:2217 > > + context.fillRoundedRect(FloatRoundedRect(barRect, barCornerRadii), controlColor.colorWithAlphaByte(alpha * 255.0f)); > > Nit - could we just use `colorWithAlpha(alpha)` instead? `colorWithAlpha` is only defined on Color, whereas controlColor is an SRGBA<uint8_t>.
Wenson Hsieh
Comment 5 2021-02-10 09:38:16 PST
Comment on attachment 419855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419855&action=review >>> Source/WebCore/rendering/RenderThemeIOS.mm:2217 >>> + context.fillRoundedRect(FloatRoundedRect(barRect, barCornerRadii), controlColor.colorWithAlphaByte(alpha * 255.0f)); >> >> Nit - could we just use `colorWithAlpha(alpha)` instead? > > `colorWithAlpha` is only defined on Color, whereas controlColor is an SRGBA<uint8_t>. I see — looks fine then!
EWS
Comment 6 2021-02-10 11:27:40 PST
Committed r272665: <https://commits.webkit.org/r272665> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419855 [details].
Note You need to log in before you can comment on or make changes to this bug.