Bug 221677 – Rework RGB color types to be more declarative to reduce code duplication and make progress toward better automatic conversion

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Sam Weinig]

Rework RGB color types to be more declarative to reduce code duplication and make progress toward better automatic conversion.

[Sam Weinig]

Created attachment 419869 [details]
Patch

[Sam Weinig]

Created attachment 419927 [details]
Patch

[Darin Adler]

Comment on attachment 419927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419927&action=review

> Source/WebCore/ChangeLog:48
> +        more places now, and the deduction guides we had been using don't work, so we must explicitly specify

A little sad to lose the deduction guides.

> Source/WebCore/ChangeLog:54
> +        intend to remove in a previous patch, but I am not actual sure is necessary. While I work that out, 

Even though I am the one who pointed it out, I think it’s not necessary.

[Sam Weinig]

(In reply to Darin Adler from comment #3)
> Comment on attachment 419927 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419927&action=review
> 
> > Source/WebCore/ChangeLog:48
> > +        more places now, and the deduction guides we had been using don't work, so we must explicitly specify
> 
> A little sad to lose the deduction guides.

Me too, though I think it is the right tradeoff for the time being. I believe c++20 fixes this. Interestingly, it is the same paper that fixes the inherited constructor issue I noted in a previous patch - http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1021r5.html

(I seem to running up against the limits of modern c++ :) ).

[EWS]

Committed r272731: <https://commits.webkit.org/r272731>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419927 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74235403>