Bug 221649 – [watchOS] Adopt PUICQuickboardController for text input

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

SSIA

[Wenson Hsieh]

Created attachment 419816 [details]
Patch

[Tim Horton]

Comment on attachment 419816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419816&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6569
> +    // establishes a connection to the quickboard view service before presenting the remote view controller.

I wonder if quickboard is a proper noun or a daemon name (should it be capitalized or not?)

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:52
> +#if PLATFORM(WATCHOS)

Technically would be better if these were all HAVE(PEPPER_UI_CORE) (at least, I think that is the right direction for Sam's PLATFORM eradication project), but this is fine for now.

[Wenson Hsieh]

Comment on attachment 419816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419816&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6569
>> +    // establishes a connection to the quickboard view service before presenting the remote view controller.
> 
> I wonder if quickboard is a proper noun or a daemon name (should it be capitalized or not?)

Ah yes, quickboard, the quickboar daemon 😅.

(Jokes aside, Quickboard should probably be capitalized, although PepperUICore sources refer to the view service as `QuickboardViewService`, so I'll change it to that instead.)

>> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:52
>> +#if PLATFORM(WATCHOS)
> 
> Technically would be better if these were all HAVE(PEPPER_UI_CORE) (at least, I think that is the right direction for Sam's PLATFORM eradication project), but this is fine for now.

That's a good point — I'll replace all the `PLATFORM(WATCHOS)`-es around our Quickboard code with `HAVE(PEPPER_UI_CORE)` in a followup.

[Wenson Hsieh]

Created attachment 419847 [details]
Patch for landing

[EWS]

Committed r272659: <https://commits.webkit.org/r272659>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419847 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74206358>