Bug 221649 - [watchOS] Adopt PUICQuickboardController for text input
Summary: [watchOS] Adopt PUICQuickboardController for text input
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-09 21:01 PST by Wenson Hsieh
Modified: 2021-02-10 14:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (49.43 KB, patch)
2021-02-09 22:09 PST, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (49.41 KB, patch)
2021-02-10 08:29 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-02-09 21:01:45 PST
SSIA
Comment 1 Wenson Hsieh 2021-02-09 22:09:16 PST
Created attachment 419816 [details]
Patch
Comment 2 Tim Horton 2021-02-09 23:17:26 PST
Comment on attachment 419816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419816&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6569
> +    // establishes a connection to the quickboard view service before presenting the remote view controller.

I wonder if quickboard is a proper noun or a daemon name (should it be capitalized or not?)

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:52
> +#if PLATFORM(WATCHOS)

Technically would be better if these were all HAVE(PEPPER_UI_CORE) (at least, I think that is the right direction for Sam's PLATFORM eradication project), but this is fine for now.
Comment 3 Wenson Hsieh 2021-02-10 08:26:10 PST
Comment on attachment 419816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419816&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6569
>> +    // establishes a connection to the quickboard view service before presenting the remote view controller.
> 
> I wonder if quickboard is a proper noun or a daemon name (should it be capitalized or not?)

Ah yes, quickboard, the quickboar daemon 😅.

(Jokes aside, Quickboard should probably be capitalized, although PepperUICore sources refer to the view service as `QuickboardViewService`, so I'll change it to that instead.)

>> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:52
>> +#if PLATFORM(WATCHOS)
> 
> Technically would be better if these were all HAVE(PEPPER_UI_CORE) (at least, I think that is the right direction for Sam's PLATFORM eradication project), but this is fine for now.

That's a good point — I'll replace all the `PLATFORM(WATCHOS)`-es around our Quickboard code with `HAVE(PEPPER_UI_CORE)` in a followup.
Comment 4 Wenson Hsieh 2021-02-10 08:29:25 PST
Created attachment 419847 [details]
Patch for landing
Comment 5 EWS 2021-02-10 09:08:04 PST
Committed r272659: <https://commits.webkit.org/r272659>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419847 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-10 14:27:26 PST
<rdar://problem/74206358>