Bug 221642 - WebCore::createBusFromInMemoryAudioFile() may crash under ExtAudioFileRead()
Summary: WebCore::createBusFromInMemoryAudioFile() may crash under ExtAudioFileRead()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-09 17:05 PST by Chris Dumez
Modified: 2021-02-10 12:34 PST (History)
9 users (show)

See Also:

Attachments
Patch (19.10 KB, patch)
2021-02-09 17:17 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-02-09 17:05:54 PST 
WebCore::createBusFromInMemoryAudioFile() may crash under ExtAudioFileRead():
 6 libAudioToolboxUtility.dylib: CrashIfClientProvidedBogusAudioBufferList <==
        6 AudioToolboxCore: ExtAudioFileRead
          6 WebCore: WebCore::createBusFromInMemoryAudioFile(void const*, unsigned long, bool, float)
            6 WebCore: WebCore::AudioBuffer::createFromAudioFileData(void const*, unsigned long, bool, float)
              6 WebCore: WTF::Detail::CallableWrapper<WebCore::AsyncAudioDecoder::AsyncAudioDecoder()::$_0, void>::call()
                6 JavaScriptCore: WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*)
                  6 JavaScriptCore: WTF::wtfThreadEntryPoint(void*)
                    6 libsystem_pthread.dylib: _pthread_start
                      6 libsystem_pthread.dylib:
Comment 1 Chris Dumez 2021-02-09 17:06:08 PST 
<rdar://72789841>
Comment 2 Chris Dumez 2021-02-09 17:17:51 PST 
Created attachment 419789 [details]
Patch
Comment 3 Geoffrey Garen 2021-02-09 20:51:31 PST 
Comment on attachment 419789 [details]
Patch

r=me
Comment 4 EWS 2021-02-10 12:34:27 PST 
Committed r272678: <https://commits.webkit.org/r272678>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419789 [details].