Bug 221632 - Don't crash when reparsing an arrow function and the parsing invariant is broken
Summary: Don't crash when reparsing an arrow function and the parsing invariant is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 221633
  Show dependency tree / graph
 
Reported: 2021-02-09 14:39 PST by Saam Barati
Modified: 2021-02-10 10:47 PST (History)
6 users (show)

See Also:

Attachments
patch (2.65 KB, patch)
2021-02-09 15:01 PST, Saam Barati 		tzagallo: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (2.66 KB, patch)
2021-02-10 08:54 PST, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-02-09 14:39:39 PST 
...
Comment 1 Saam Barati 2021-02-09 14:40:03 PST 
<rdar://71874091>
Comment 2 Saam Barati 2021-02-09 15:01:40 PST 
Created attachment 419771 [details]
patch
Comment 3 Tadeu Zagallo 2021-02-09 15:02:59 PST 
Comment on attachment 419771 [details]
patch

r=me
Comment 4 Mark Lam 2021-02-09 15:04:43 PST 
Comment on attachment 419771 [details]
patch

r=me too
Comment 5 EWS 2021-02-09 16:34:31 PST 
commit-queue failed to commit attachment 419771 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 6 EWS 2021-02-09 19:08:47 PST 
commit-queue failed to commit attachment 419771 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 7 Saam Barati 2021-02-10 08:54:39 PST 
Created attachment 419851 [details]
patch for landing
Comment 8 EWS 2021-02-10 10:41:10 PST 
Found 1 new test failure: http/tests/media/hls/video-duration-accessibility.html
Comment 9 Saam Barati 2021-02-10 10:43:27 PST 
(In reply to EWS from comment #8)
> Found 1 new test failure:
> http/tests/media/hls/video-duration-accessibility.html

No
Comment 10 Saam Barati 2021-02-10 10:47:30 PST 
landed in:
https://trac.webkit.org/changeset/272663/webkit