Bug 221625 – [GTK] Export additional methods of SourceBufferPrivate to support hidden visibility

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Don Olmstead]

....

[Don Olmstead]

Created attachment 419757 [details]
Patch

[Michael Catanzaro]

I can only imagine why these are needed, especially since WebCore is the toplevel library... I guess a test program is using them?

[Don Olmstead]

(In reply to Michael Catanzaro from comment #2)
> I can only imagine why these are needed, especially since WebCore is the
> toplevel library... I guess a test program is using them?

From https://ews-build.webkit.org/#/builders/36/builds/27419 which didn't export those symbols.

lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::setMediaSourceEnded(bool)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::reenqueueMediaIfNeeded(WTF::MediaTime const&, unsigned long, unsigned long)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::addTrackBuffer(WTF::AtomString const&, WTF::RefPtr<WebCore::MediaDescription, WTF::RawPtrTraits<WebCore::MediaDescription>, WTF::DefaultRefDerefTraits<WebCore::MediaDescription> >&&)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::resetTrackBuffers()'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::clearTrackBuffers()'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::setAllTrackBuffersNeedRandomAccess()'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::removeCodedFrames(WTF::MediaTime const&, WTF::MediaTime const&, WTF::MediaTime const&, bool, WTF::CompletionHandler<void ()>&&)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::resetTimestampOffsetInTrackBuffers()'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::seekToTime(WTF::MediaTime const&)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::updateTrackIds(WTF::Vector<std::pair<WTF::AtomString, WTF::AtomString>, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)'

[EWS]

Committed r272632: <https://commits.webkit.org/r272632>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419757 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74206399>