Bug 221623 - [WebAuthn] Produce ClientDataJSON in the SPI
Summary: [WebAuthn] Produce ClientDataJSON in the SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-09 12:45 PST by Jiewen Tan
Modified: 2021-02-10 15:50 PST (History)
3 users (show)

See Also:


Attachments
Patch (25.94 KB, patch)
2021-02-09 13:54 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch for landing (26.18 KB, patch)
2021-02-10 15:02 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-02-09 12:45:04 PST
Produce ClientDataJSON in the SPI.
Comment 1 Jiewen Tan 2021-02-09 12:47:05 PST
<rdar://problem/71509394>
Comment 2 Jiewen Tan 2021-02-09 13:54:19 PST
Created attachment 419758 [details]
Patch
Comment 3 Brent Fulgham 2021-02-10 14:08:00 PST
Comment on attachment 419758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419758&action=review

r=me, but please fix the unused function warning.

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:55
> +

These two method should be inside #if ENABLE(WEB_AUTHN)
Comment 4 Brent Fulgham 2021-02-10 15:02:26 PST
Created attachment 419909 [details]
Patch for landing
Comment 5 EWS 2021-02-10 15:50:44 PST
Committed r272694: <https://commits.webkit.org/r272694>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419909 [details].