Bug 221613 - Check if ENGINEERING_BUILD is defined before testing it
Summary: Check if ENGINEERING_BUILD is defined before testing it
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-09 10:08 PST by Michael Catanzaro
Modified: 2021-02-09 12:02 PST (History)
12 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2021-02-09 11:02 PST, Michael Catanzaro 		mcatanzaro: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2021-02-09 10:08:52 PST 
Small warning added in bug #221371:

[1385/2409] Building CXX object Source...ources/UnifiedSource-950a39b6-10.cpp.o
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-10.cpp:2:
../../Source/WebCore/html/HTMLMediaElement.cpp:7159:5: warning: "ENGINEERING_BUILD" is not defined, evaluates to 0 [-Wundef]
 7159 | #if ENGINEERING_BUILD || !defined(NDEBUG)
      |     ^~~~~~~~~~~~~~~~~

Let's test if it's defined first.
Comment 1 Michael Catanzaro 2021-02-09 11:02:45 PST 
Created attachment 419743 [details]
Patch
Comment 2 Michael Catanzaro 2021-02-09 12:02:01 PST 
Comment on attachment 419743 [details]
Patch

This will conflict with and is obsoleted by Devin's patch in bug #221621.