Bug 221598 - REGRESSION(r263255): Text styles without an explicit language tag do not honor the system language
Summary: REGRESSION(r263255): Text styles without an explicit language tag do not hono...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-09 00:58 PST by Myles C. Maxfield
Modified: 2021-02-10 11:17 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2021-02-09 01:01 PST, Myles C. Maxfield 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (4.25 KB, patch)
2021-02-09 20:50 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-02-09 00:58:46 PST 
REGRESSION(r263255): Text styles without an explicit language tag do not honor the system language
Comment 1 Myles C. Maxfield 2021-02-09 01:01:27 PST 
Created attachment 419687 [details]
Patch
Comment 2 Myles C. Maxfield 2021-02-09 01:02:11 PST 
<rdar://problem/69194294>
Comment 3 Myles C. Maxfield 2021-02-09 20:31:13 PST 
Comment on attachment 419687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419687&action=review

> LayoutTests/fast/text/international/system-language/jp-circled.html:1
> +<!DOCTYPE html><!-- webkit-test-runner [ language=jp ] -->

Oh, I think this has to be ja instead of jp
Comment 4 Myles C. Maxfield 2021-02-09 20:50:44 PST 
Created attachment 419810 [details]
Patch for committing
Comment 5 EWS 2021-02-10 07:44:14 PST 
Committed r272652: <https://commits.webkit.org/r272652>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419810 [details].
Comment 6 Darin Adler 2021-02-10 11:17:10 PST 
Comment on attachment 419810 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=419810&action=review

> Source/WebCore/ChangeLog:9
> +        The distinction between NULL and CFSTR("") strikes again!

Should we add the CF equivalent of nsStringNilIfEmpty?