WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
221585
Work around some order dependent issues by parenting remote layers before applying other properties
https://bugs.webkit.org/show_bug.cgi?id=221585
Summary
Work around some order dependent issues by parenting remote layers before app...
Sam Weinig
Reported
2021-02-08 16:04:19 PST
Workaround some order dependent issues by parenting remote layers before applying other properties
Attachments
Patch
(5.88 KB, patch)
2021-02-08 17:06 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2021-02-08 17:06:37 PST
Created
attachment 419656
[details]
Patch
EWS
Comment 2
2021-02-10 06:37:26 PST
Committed
r272647
: <
https://commits.webkit.org/r272647
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 419656
[details]
.
Darin Adler
Comment 3
2021-02-10 11:18:35 PST
Comment on
attachment 419656
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=419656&action=review
> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:99 > + const RemoteLayerTreeTransaction::LayerProperties& properties = *propertiesPointer;
Why not auto& here?
Radar WebKit Bug Importer
Comment 4
2021-02-10 14:31:19 PST
<
rdar://problem/74206528
>
Sam Weinig
Comment 5
2021-02-10 14:57:36 PST
(In reply to Darin Adler from
comment #3
)
> Comment on
attachment 419656
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=419656&action=review
> > > Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:99 > > + const RemoteLayerTreeTransaction::LayerProperties& properties = *propertiesPointer; > > Why not auto& here?
No solid reason other than I was duplication the code below and didn't notice.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug