Bug 221577 - Move layout_test_runner.Worker._update_test_input to LayoutTestRunner
Summary: Move layout_test_runner.Worker._update_test_input to LayoutTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks: 220421
  Show dependency tree / graph
 
Reported: 2021-02-08 14:58 PST by Sam Sneddon [:gsnedders]
Modified: 2021-02-10 14:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2021-02-08 15:03 PST, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2021-02-08 15:14 PST, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Patch (4.62 KB, patch)
2021-02-08 15:20 PST, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-02-08 14:58:11 PST 
There's no reason that we only actually find references for reftests on the Worker itself. By the time we reach the Worker, we really should know exactly what we're going to run.

Ideally, we'd be finding the references long before this, but for now let's move it to the LayoutTestFinder.
Comment 1 Sam Sneddon [:gsnedders] 2021-02-08 15:03:47 PST 
Created attachment 419634 [details]
Patch
Comment 2 Sam Sneddon [:gsnedders] 2021-02-08 15:14:23 PST 
Created attachment 419639 [details]
Patch
Comment 3 Sam Sneddon [:gsnedders] 2021-02-08 15:20:02 PST 
Created attachment 419643 [details]
Patch
Comment 4 EWS 2021-02-08 22:51:18 PST 
Committed r272568: <https://commits.webkit.org/r272568>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419643 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-10 14:32:18 PST 
<rdar://problem/74206576>