Bug 221575 - Use CompletionHandler instead of BoolCallback
Summary: Use CompletionHandler instead of BoolCallback
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2021-02-08 14:35 PST by Alex Christensen
Modified: 2021-02-10 14:32 PST (History)
3 users (show)

See Also:

Patch (17.97 KB, patch)
2021-02-08 14:50 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-02-08 14:35:34 PST
Use CompletionHandler instead of BoolCallback
Comment 1 Alex Christensen 2021-02-08 14:50:55 PST
Created attachment 419632 [details]
Comment 2 Chris Dumez 2021-02-08 16:11:07 PST
Comment on attachment 419632 [details]

Comment 3 EWS 2021-02-08 16:22:30 PST
Committed r272558: <https://commits.webkit.org/r272558>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419632 [details].
Comment 4 Darin Adler 2021-02-08 16:35:11 PST
Are we close to being able to remove all the callbacks?
Comment 5 Darin Adler 2021-02-08 16:35:28 PST
Kind of idly wondering if whatever BoolCallback crash we had might affect the others too.
Comment 6 Alex Christensen 2021-02-08 18:57:37 PST
I'm on my way to removing all use of GenericCallback.  It's one of those morning warm-up tasks.  It'll probably take a few more weeks.  The code that uses it is quite old and convoluted.
Comment 7 Radar WebKit Bug Importer 2021-02-10 14:32:35 PST