Bug 221573 - [LFC][Integration] Style change on an inline box should trigger invalidation
Summary: [LFC][Integration] Style change on an inline box should trigger invalidation
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2021-02-08 14:12 PST by zalan
Modified: 2021-02-10 14:32 PST (History)
11 users (show)

See Also:

Patch (1.81 KB, patch)
2021-02-08 14:17 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2021-02-09 11:21 PST, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-02-08 14:12:34 PST
full invalidation at this point.
Comment 1 zalan 2021-02-08 14:17:03 PST
Created attachment 419626 [details]
Comment 2 Antti Koivisto 2021-02-08 22:12:21 PST
Comment on attachment 419626 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=419626&action=review

> Source/WebCore/rendering/RenderInline.cpp:200
> +        if (needsLayout()) {

Probably selfNeedsLayout()

We may also need descendant canUse test similar to canUseForAfterStyleChange.

> Source/WebCore/rendering/RenderInline.cpp:202
> +            downcast<RenderBlockFlow>(*containingBlock()).invalidateLineLayoutPath();

There is LineLayout::blockContainer I have been using for this sort of things.
Comment 3 zalan 2021-02-09 11:21:45 PST
Created attachment 419745 [details]
Comment 4 EWS 2021-02-09 12:24:43 PST
Committed r272601: <https://commits.webkit.org/r272601>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419745 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-10 14:32:54 PST