Bug 221554 - [Flatpak] http server is not properly tear down
Summary: [Flatpak] http server is not properly tear down
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-08 08:11 PST by Xabier Rodríguez Calvar
Modified: 2021-11-11 06:56 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2021-09-20 04:42 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2021-02-08 08:11:15 PST
1. Run http tests, that force the http server to be spawed. In my case I used http/tests/webgl/1.0.2/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html in parallel 100 times.
2. Before it ends, press Ctrl+C to shut down the testing.
3. Goto 1. It will fail as the server could not be spawned.
Comment 1 Philippe Normand 2021-02-12 02:46:34 PST
In case WebKitBuild/GTK/Release/layout-test-results/error_log.txt mentions "Error: (17)File exists: unable to create scoreboard"

the workaround is to manually remove stale SHM segments:

https://makandracards.com/fabio-silva/49967-apache-unable-to-create-scoreboard-shared-memory-failure

I suppose we could automate this though.
Comment 2 Xabier Rodríguez Calvar 2021-02-12 03:50:22 PST
I think that clean up should be implemented before launching the server.
Comment 3 Philippe Normand 2021-09-20 04:42:16 PDT
Created attachment 438656 [details]
Patch
Comment 4 Lauro Moura 2021-10-13 12:46:47 PDT
Tested locally and it's working as expected, cleaning the stale segments and allowing the server to start normally.
Comment 5 Adrian Perez 2021-11-11 05:48:50 PST
Comment on attachment 438656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438656&action=review

> Tools/ChangeLog:10
> +        'scoreboard' with SHM. The proposed solution is to look for stale SHM segments, eg. segments

TIL that Apache still uses SysV persistent SHM segments 🤯️
Comment 6 EWS 2021-11-11 06:55:36 PST
Committed r285627 (244128@main): <https://commits.webkit.org/244128@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438656 [details].
Comment 7 Radar WebKit Bug Importer 2021-11-11 06:56:44 PST
<rdar://problem/85297816>